feat(instance): add terminate command #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command uses the server action API: with `action=terminate` https://developers.scaleway.com/en/products/instance/api/#post-049a5b to quickly delete an instance without backing up its attached volumes. Options: * `with-ip`: also delete the flexible IPs * `with-block`: by default, `terminate` will delete the block storage volumes. When `false`, the command will detach the block volumes before calling `terminate`
|
Maybe we could add an interactive question when with-block is not specified. |
|
@remyleone terminate will now prompt the user iff:
example: |
remyleone
previously approved these changes
May 5, 2020
jerome-quere
suggested changes
May 5, 2020
jerome-quere
suggested changes
May 6, 2020
remyleone
reviewed
May 6, 2020
remyleone
reviewed
May 6, 2020
remyleone
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command uses the server action API: with
action=terminatehttps://developers.scaleway.com/en/products/instance/api/#post-049a5b to quickly delete an instance without backing up its attached volumes.Options:
with-ip: also delete the flexible IPswith-block: by default,terminatewill delete the block storage volumes. Whenfalse, the command will detach the block volumes before callingterminateWhat remains to be decided:
with-block:trueto match the API/SDK orfalseto avoid accidental data loss (though when you callterminate, you should expect stuff to be ... terminated.Closes #921